[ 
https://issues.apache.org/jira/browse/CALCITE-5874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17748709#comment-17748709
 ] 

Julian Hyde commented on CALCITE-5874:
--------------------------------------

I think you should squash this commit into CALCITE-5831.

I created issue links so that it's easier for reviewers to tie these things 
together.

> Add withReturnTypeInference copy method for SqlBasicFunction
> ------------------------------------------------------------
>
>                 Key: CALCITE-5874
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5874
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.34.0
>            Reporter: Ran Tao
>            Assignee: Ran Tao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.36.0
>
>
> some sql functions have same sqlkind and name but with different return types.
> e.g. Soundex function, calcite and bigquery return varchar(4), however spark 
> return non-fixed length. If we want reuse Soundex, we can only use create 
> method to pass all parameters, it's a bit bloated. 
> If we add a `withReturnTypeInference()`, we can simply use this to copy from 
> existed functions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to