[ 
https://issues.apache.org/jira/browse/CALCITE-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750274#comment-17750274
 ] 

xiong duan commented on CALCITE-5875:
-------------------------------------

[~taoran], How about we change the issue summary to "Remove unnecessary NULL 
checks in Redis adapter" to keep the commit info format? 

> Remove some unnecessary null checks for redis adapter
> -----------------------------------------------------
>
>                 Key: CALCITE-5875
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5875
>             Project: Calcite
>          Issue Type: Improvement
>    Affects Versions: 1.34.0
>            Reporter: Ran Tao
>            Assignee: Ran Tao
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.36.0
>
>
> It's minor fix to remove some unnecessary null checks for redis-adapter.
> e.g.
> {code:java}
> if (REDIS_CONTAINER != null && REDIS_CONTAINER.isRunning()) {
>   REDIS_CONTAINER.stop();
> } {code}
> however REDIS_CONTAINER is static variable must not be null unless cause 
> exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to