[ 
https://issues.apache.org/jira/browse/CALCITE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17752224#comment-17752224
 ] 

LakeShen commented on CALCITE-5895:
-----------------------------------

Hi,[~julianhyde] ,thank you very much for your patient reply,I have got your 
point.You provided a lot of information for me.

I have the same thought with you for add implementation of {{TABLESAMPLE}} in 
enumerable mode,because I was going to add the TABlESAMPLE(0) test case in 
misc.iq, but it says that Sample doesn't have an implementation,we could track 
the add implementation of TABLESAMPLE in enumerable mode by creating a JIRA.

> The result of table sample rate 0  is incorrect result and should return the 
> empty result
> -----------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5895
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5895
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: LakeShen
>            Assignee: LakeShen
>            Priority: Major
>             Fix For: 1.36.0
>
>         Attachments: image-2023-08-05-22-45-02-513.png
>
>
> For The sql:
> {code:java}
> select * from emp tablesample bernoulli(0) where empno > 5
> {code}
> The plan is :
> {code:java}
> LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4], 
> SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8])
>   LogicalFilter(condition=[>($0, 5)])
>     LogicalTableScan(table=[[CATALOG, SALES, EMP]])
> {code}
> I think the correct result of above SQL is empty.
> But its result is the following SQL result:
> {code:java}
> select * from emp where empno > 5
> {code}
> It's an incorrect result



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to