[ https://issues.apache.org/jira/browse/CALCITE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754338#comment-17754338 ]
Julian Hyde commented on CALCITE-5906: -------------------------------------- The PR looks good. Can you rebase it onto main (which now contains CALCITE-5895 and CALCITE-5916). Also change the summary (and commit message, and descriptions of test cases) so that it reads like a feature request, something like "JDBC adapter should generate TABLESAMPLE". > Add the visit(Sample e) implementation in RelToSqlConverter > ------------------------------------------------------------- > > Key: CALCITE-5906 > URL: https://issues.apache.org/jira/browse/CALCITE-5906 > Project: Calcite > Issue Type: Bug > Reporter: LakeShen > Assignee: LakeShen > Priority: Major > Labels: pull-request-available > Fix For: 1.36.0 > > Attachments: image-2023-08-08-20-16-27-188.png, > image-2023-08-08-20-19-01-269.png > > > Currently in the RelToSqlConverter class, there is no visit method to handle > the Sample RelNode.If a SQL plan has Sample RelNode, RelToSqlConverter will > throw a AssertionError like this: > {code:java} > java.lang.AssertionError: Need to implement > org.apache.calcite.rel.core.Sample > {code} > This will cause the Sample RelNode plan to fail to translate to the > corresponding dialect. -- This message was sent by Atlassian Jira (v8.20.10#820010)