[
https://issues.apache.org/jira/browse/CALCITE-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757903#comment-17757903
]
Benchao Li commented on CALCITE-5909:
-------------------------------------
[~taoran] I see used a different commit message from the Jira title, usually we
keep them the same, concisely describe the symptoms or what should be the
expected behavior.
I presume that "Sometimes" is not needed, it should "always" fail if you run it
in IDE directly, am I right? Then I propose to change the Jira title and commit
message to "SqlParserTest.testNoUnintendedNewReservedKeywords fails in IDE
while passes in command line", if you and others agree, I'll go on and merge it
with this message.
> Sometimes SqlParserTest.testNoUnintendedNewReservedKeywords fails in the IDE
> but passes when run from the command line
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: CALCITE-5909
> URL: https://issues.apache.org/jira/browse/CALCITE-5909
> Project: Calcite
> Issue Type: Bug
> Components: tests
> Reporter: LakeShen
> Assignee: Ran Tao
> Priority: Minor
> Labels: pull-request-available
> Attachments: image-2023-08-08-23-32-55-466.png
>
>
> When I run the SqlParserTest,the testNoUnintendedNewReservedKeywords method
> failed,the exception like this:
> {code:java}
> java.lang.AssertionError: The parser has at least one new reserved keyword.
> Are you sure it should be reserved? Difference: {code}
> The picture like this:
> !image-2023-08-08-23-32-55-466.png|width=1543,height=496!
> I could fix this problem.More importantly, why is this method failing, but
> the Calcite pipeline is passing? I think we should look at something we missed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
