[ https://issues.apache.org/jira/browse/CALCITE-6020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769671#comment-17769671 ]
Julian Hyde commented on CALCITE-6020: -------------------------------------- I agree that the subset of algebra we target should be more configurable (as long as the configuration is structured so as not be bewildering). Recently I have been making SqlToRelConverter lean ever more heavily on RelBuilder. We should continue in that direction. RelBuilder is nicely configurable, and if we want SqlToRelConverter to perform simplifications as it goes, it is better that that code lives in RelBuilder where it can be reused, better tested, and disabled. > SqlToRelConverter should not replace windowed SUM with equivalent expression > using SUM0 > --------------------------------------------------------------------------------------- > > Key: CALCITE-6020 > URL: https://issues.apache.org/jira/browse/CALCITE-6020 > Project: Calcite > Issue Type: Improvement > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Labels: pull-request-available > > {{SqlToRelConverter}} replaces {{SUM}} with {{SUM0}} around > [here|https://github.com/apache/calcite/blob/e1991e08a225ef08c2402ab35c310d88fff3c222/core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L5885] > This might have been needed at some point in the past - but I think it will > be better to leave it as {{SUM}} - as in case there is no {{SUM0}} in the > system that will be replaced with a {{COALESCE(SUM(...) , 0 )}} to provide it > - as see > [here|https://github.com/apache/calcite/blob/e1991e08a225ef08c2402ab35c310d88fff3c222/core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java#L1288] -- This message was sent by Atlassian Jira (v8.20.10#820010)