[ 
https://issues.apache.org/jira/browse/CALCITE-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775893#comment-17775893
 ] 

Julian Hyde commented on CALCITE-3933:
--------------------------------------

A related issue is CALCITE-6001. If Calcite knows that a DB can handle a larger 
character set, it can generate literals in that character set, and won't need 
to use Unicode encoding.

> Incorrect SQL Emitted for Unicode for Several Dialects
> ------------------------------------------------------
>
>                 Key: CALCITE-3933
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3933
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.22.0
>         Environment: master with latest commit on April 15 (
> dfb842e55e1fa7037c8a731341010ed1c0cfb6f7)
>            Reporter: Aryeh Hillman
>            Priority: Major
>
> A string literal like "schön" should emit "schön" in SQL for many dialects, 
> but instead emits
> {code:java}
> u&'sch\\00f6n' {code}
> which is (ISO-8859-1 ASCII). 
> It's possible that some of the above dialects may support ISO-8859, but in my 
> tests with *BigQuery Standard SQL*, *MySQL*, and *Redshift* engines, the 
> following fails:
> {code:java}
> select u&'sch\\00f6n';{code}
> But this succeeds:
> {code:java}
> select 'schön'; {code}
> Test that demonstrates (add to 
> `org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java` and run from 
> there):
> {code:java}
> @Test void testBigQueryUnicode() {
>   final Function<RelBuilder, RelNode> relFn = b ->
>           b.scan("EMP")
>                   .filter(
>                           b.call(SqlStdOperatorTable.IN, b.field("ENAME"),
>                                   b.literal("schön")))
>                   .build();
>   final String expectedSql = "SELECT *\n" +
>           "FROM scott.EMP\n" +
>           "WHERE ENAME IN ('schön')";
>   relFn(relFn).withBigQuery().ok(expectedSql);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to