[
https://issues.apache.org/jira/browse/CALCITE-6052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775982#comment-17775982
]
Julian Hyde commented on CALCITE-6052:
--------------------------------------
Good idea. I like small changes. I suggest changing 'FLOATING POINT' to 'REAL,
FLOAT and DOUBLE' in the summary, since those are the specific SQL type names.
One test in the Pig module isn't sufficient. Can you add a test, with one
column for each type, in SqlToRelConverterTest.
Do a quick experiment to see whether IEEE special values work (+inf, -inf, nan,
-0), and if so, add them to the test. I don't recall whether SQL supports those
values, but the test could at least document our current behavior.
> SqlImplementor writes FLOATING POINT literals as DECIMAL literals
> -----------------------------------------------------------------
>
> Key: CALCITE-6052
> URL: https://issues.apache.org/jira/browse/CALCITE-6052
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Mihai Budiu
> Assignee: Mihai Budiu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.36.0
>
>
> This bug is already fixed in https://github.com/apache/calcite/pull/3411, but
> I plan to submit a smaller point fix for it, which doesn't require reworking
> the type families.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
