[
https://issues.apache.org/jira/browse/CALCITE-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779473#comment-17779473
]
Benchao Li commented on CALCITE-5921:
-------------------------------------
AFAIK, the CI runs as a "virtual merge commit" with latest main branch, which
means that if there are more commits after the CI runs, that wouldn't be
checked in current PR's CI. That says, we only need to check the commits
committed after the CI triggered.
> SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure
> ---------------------------------------------------------------------------
>
> Key: CALCITE-5921
> URL: https://issues.apache.org/jira/browse/CALCITE-5921
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.36.0
>
>
> SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure.
> See more in [code
> line|https://github.com/apache/calcite/blob/50c3edfc3d6630528ab51fe836bd50df82cc7db8/testkit/src/main/java/org/apache/calcite/test/SqlOperatorFixtureImpl.java#L160].
> When the parameter `runtime` of SqlOperatorFixture.checkFails is true, it
> should execute the query and check runtime failure, but currently it ignores
> this, and only checks the parse and validation failure.
> When fix this, there are 4 failed test cases in CalciteSqlOperatorTest.
> At last, this issue was found when to implement `BIT_GET` function in
> CALCITE-5848.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
