[
https://issues.apache.org/jira/browse/CALCITE-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779451#comment-17779451
]
Ruben Q L edited comment on CALCITE-5921 at 10/25/23 12:10 PM:
---------------------------------------------------------------
I have the impression that the problem comes from the recent changes introduced
by CALCITE-5923 (UPDATE: and CALCITE-6014), which were not part of [~mbudiu]'s
PR (because the branch was created before CALCITE-5923/CALCITE-6014 was
merged). Probably some adjustments are needed to make the ensemble work fine,
wip...
was (Author: rubenql):
I have the impression that the problem comes from the recent changes introduced
by CALCITE-5923, which were not part of [~mbudiu]'s PR (because the branch was
created before CALCITE-5923 was merged). Probably some adjustments are needed
to make the ensemble work fine, wip...
> SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure
> ---------------------------------------------------------------------------
>
> Key: CALCITE-5921
> URL: https://issues.apache.org/jira/browse/CALCITE-5921
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.35.0
> Reporter: Runkang He
> Assignee: Runkang He
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.36.0
>
>
> SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure.
> See more in [code
> line|https://github.com/apache/calcite/blob/50c3edfc3d6630528ab51fe836bd50df82cc7db8/testkit/src/main/java/org/apache/calcite/test/SqlOperatorFixtureImpl.java#L160].
> When the parameter `runtime` of SqlOperatorFixture.checkFails is true, it
> should execute the query and check runtime failure, but currently it ignores
> this, and only checks the parse and validation failure.
> When fix this, there are 4 failed test cases in CalciteSqlOperatorTest.
> At last, this issue was found when to implement `BIT_GET` function in
> CALCITE-5848.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
