[ 
https://issues.apache.org/jira/browse/CALCITE-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788143#comment-17788143
 ] 

Julian Hyde commented on CALCITE-6125:
--------------------------------------

{quote}How is the RM supposed to figure out the real name ?{quote}

Release managers generally figure out real names from the author in the commit, 
the name attached to the GitHub user, the name attached to the Jira user.

{quote}Not every contributor name may be available, and tasking the RM with 
investigating this seems to be too much.{quote}

Release managers have done this for several releases (since 1.29). Before that, 
we would include contributor names in commit messages (if they were not yet 
committers), and appending contributor names was a burden on committers.

{quote}Is this a requirement by ASF policies ?{quote}

ASF policies neither require it nor prevent it. ASF policies require us to make 
releases, releases are accompanied by release notes, and compiling the list of 
contributors is part of the task of compiling release notes.

I believe that giving contributors credit in the release notes helps us grow 
community.

> Automate generation of contributor names in release notes
> ---------------------------------------------------------
>
>                 Key: CALCITE-6125
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6125
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>            Priority: Major
>              Labels: pull-request-available
>
> Automate generation of contributor names in release notes. Currently the 
> process requires manual effort because people do not use their real name in 
> the author field of their git commit.
> For example, consider generating the list for release 1.32.0. Here is a rough 
> process:
> {noformat}
> $ git log calcite-1.31.0..calcite-1.32.0 | egrep 'Author:|Co-authored-by:' | 
> sort -u
> Author: Alessandro Solimando <alessandro.solima...@gmail.com>
> Author: almansour <ali.mans...@murex.com>
> Author: Andrei Sereda <25229979+asereda...@users.noreply.github.com>
> Author: Benchao Li <libenc...@gmail.com>
> Author: Bertil Chapuis <bchap...@gmail.com>
> Author: chunwei.lcw <chunwei.l...@gmail.com>
> Author: dssysolyatin <dm.sysolya...@gmail.com>
> Author: Julian Hyde <jh...@apache.org>
> Author: lincoln.lil <lincoln....@alibaba-inc.com>
> Author: rubenada <rube...@gmail.com>
> Author: strongduanmu <duanzhengqi...@apache.org>
> Author: TJ Banghart <tjbangh...@google.com>
> Author: wumou.wm <wumou...@alibaba-inc.com>
> Author: xiejiajun <jiajunbernou...@foxmail.com>
>     Co-authored-by: David Handermann <exceptionfact...@apache.org>
> {noformat}
> If we add a [git mailmap file|https://git-scm.com/docs/gitmailmap], 
> {{.mailmap}}, we can translate some of the names 'lincolon.lil' to 'Lincoln 
> Lee' and 'wumou.wm' to 'Mou Wu':
> {noformat}
> $ git log calcite-1.31.0..calcite-1.32.0 |egrep 'Author:|Co-authored-by:' 
> |sort -u
> Author: Alessandro Solimando <alessandro.solima...@gmail.com>
> Author: Ali Mansour <ali.mans...@murex.com>
> Author: Andrei Sereda <25229979+asereda...@users.noreply.github.com>
> Author: Benchao Li <libenc...@gmail.com>
> Author: Bertil Chapuis <bchap...@gmail.com>
> Author: chunwei.lcw <chunwei.l...@gmail.com>
> Author: dssysolyatin <dm.sysolya...@gmail.com>
> Author: Jiajun Xie <jiajunbernou...@foxmail.com>
> Author: Julian Hyde <jh...@apache.org>
> Author: Lincoln Lee <lincoln....@alibaba-inc.com>
> Author: Mou Wu <wumou...@alibaba-inc.com>
> Author: Ruben Quesada Lopez <rube...@gmail.com>
> Author: TJ Banghart <tjbangh...@google.com>
> Author: Zhengqiang Duan <duanzhengqi...@apache.org>
>     Co-authored-by: David Handermann <exceptionfact...@apache.org>
> {noformat}
> I propose to add a mailmap file, and change the release process so that the 
> release manager must modify the mailmap to achieve the right names in the 
> release notes (not edit the names manually).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to