[
https://issues.apache.org/jira/browse/CALCITE-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802846#comment-17802846
]
Caican Cai edited comment on CALCITE-6184 at 1/4/24 10:46 AM:
--------------------------------------------------------------
I will summarize and sort out those checknulls that should be added with
checknull test later.
# It is necessary to add a checknull test to datefunction because bugs may be
hidden here e.g. [[MINOR] Add checkNull Test on SqlOperatorTest by caicancai ·
Pull Request #3596 · apache/calcite
(github.com)|https://github.com/apache/calcite/pull/3596]
# I tried adding a checknull test to the Map, but it seems unnecessary
was (Author: JIRAUSER302115):
I will summarize and sort out those checknulls that should be added with
checknull test later.
# It is necessary to add a checknull test to datefunction because bugs may be
hidden here e.g[[MINOR] Add checkNull Test on SqlOperatorTest ·
apache/calcite@6e7b05d
(github.com)|https://github.com/apache/calcite/commit/6e7b05d7767381c9928fea7caed6dcb08b54a63f]
# I tried adding a checknull test to the Map, but it seems unnecessary
> Add checkNullTest on SqlOperatorTest
> ------------------------------------
>
> Key: CALCITE-6184
> URL: https://issues.apache.org/jira/browse/CALCITE-6184
> Project: Calcite
> Issue Type: Test
> Components: tests
> Affects Versions: 1.36.0
> Reporter: Caican Cai
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.37.0
>
>
> Some tests in calcite's SqlOperatorTest lack checknull. I think the checknull
> test should be added.
> 1. Conducive to the learning of new developers
> 2. Based on the checknull test, we may be able to find some bugs in calcite’s
> sqoperator.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
