[ 
https://issues.apache.org/jira/browse/CALCITE-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813815#comment-17813815
 ] 

Julian Hyde commented on CALCITE-6237:
--------------------------------------

[~caicancai], Do you understand why I closed CALCITE-6232 as invalid? This 
issue has the same problems.

I have noticed that, compared to other contributors, your contributions to 
Calcite require a lot of time to review. And the time of our committers – who 
are all volunteers – is limited. One way you can improve is by addressing the 
feedback you receive. In the other case I said "Closing as invalid; you can 
reopen if you make it about either log functions or division, but not both" but 
you ignored that advice.

> Using fractions in LOG function does not return correct results
> ---------------------------------------------------------------
>
>                 Key: CALCITE-6237
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6237
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.36.0
>            Reporter: Caican Cai
>            Priority: Major
>             Fix For: 1.37.0
>
>
> {code:java}
> mysql> SELECT LOG10(2/3) AS result;
> +---------------------+
> | result              |
> +---------------------+
> | -0.1760912594899757 |
> +---------------------+
> 1 row in set (0.00 sec)
> mysql> SELECT LOG2(0) AS result;
> +--------+
> | result |
> +--------+
> |   NULL |
> +--------+
> 1 row in set, 1 warning (0.01 sec)
> mysql> SELECT LOG2(2/3) AS result;
> +---------------------+
> | result              |
> +---------------------+
> | -0.5849625021638512 |
> +---------------------+
> 1 row in set (0.00 sec)
>   {code}
> When using Calcite's Log2 and Log10 functions, if the parameter is a 
> fraction, the integer digits will be retained by default. I think this is 
> wrong. Several decimal places (such as tens) should be retained by default.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to