[ 
https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817527#comment-17817527
 ] 

Mihai Budiu commented on CALCITE-6248:
--------------------------------------

I have a question about this Quidem test in misc.iq:

{code}
# Slightly different format
# (Incidentally, this format is not allowed in date literals, per the standard)
values cast('1989-7-4' as date);
{code}

This test explicitly assumes that casts are more liberal in the date formats 
they accept than date literals. Is this true? If so, then this whole bugfix has 
to be rethought. [~julianhyde] you actually wrote this test in 2016.


> Illegal dates are accepted by casts
> -----------------------------------
>
>                 Key: CALCITE-6248
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6248
>             Project: Calcite
>          Issue Type: Bug
>          Components: avatica, core
>    Affects Versions: 1.36.0
>            Reporter: Mihai Budiu
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The following test passes in SqlOperatorTest:
> {code:java}
>   @Test public void testIllegalDate() {
>     final SqlOperatorFixture f = fixture();
>     f.checkScalar("cast('1945-02-32' as DATE)",
>         "1945-03-04", "DATE NOT NULL");
>   }
> {code}
> There is no February 32, I suspect that this expression should produce an 
> error.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to