[ https://issues.apache.org/jira/browse/CALCITE-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819856#comment-17819856 ]
Julian Hyde edited comment on CALCITE-6210 at 2/23/24 12:14 AM: ---------------------------------------------------------------- {quote} The problem with my approach is that other dialects of SQL may want a different behavior {quote} Yes, but let's do it in two steps. First, and most important, let's have an agreed (and documented) default behavior. Second, provide a way for dialects (actually I believe we're talking about conformances) to override. Reading the code, I see that CALCITE-3550 had that second goal. If it doesn't work for you, should we log a new case proposing an improved extensibility mechanism? was (Author: julianhyde): {quote}The problem with my approach is that other dialects of SQL may want a different behavior\{quote} Yes, but let's do it in two steps. First, and most important, let's have an agreed (and documented) default behavior. Second, provide a way for dialects (actually I believe we're talking about conformances) to override. Reading the code, I see that CALCITE-3550 had that second goal. If it doesn't work for you, should we log a new case proposing an improved extensibility mechanism? > Cast to VARBINARY causes an assertion failure > --------------------------------------------- > > Key: CALCITE-6210 > URL: https://issues.apache.org/jira/browse/CALCITE-6210 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.36.0 > Reporter: Mihai Budiu > Priority: Minor > Labels: pull-request-available > > This test in SqlOperatorTest: > {code:java} > SqlOperatorFixture f = fixture(); > f.checkScalar("CAST('00' AS VARBINARY)", "00", "VARBINARY NOT NULL"); > {code} > Causes the following assertion failure: > {code} > java.lang.AssertionError: value 00 does not match type class > org.apache.calcite.avatica.util.ByteString > at > org.apache.calcite.linq4j.tree.ConstantExpression.<init>(ConstantExpression.java:51) > at > org.apache.calcite.linq4j.tree.Expressions.constant(Expressions.java:585) > at > org.apache.calcite.linq4j.tree.OptimizeShuttle.visit(OptimizeShuttle.java:305) > at > org.apache.calcite.linq4j.tree.UnaryExpression.accept(UnaryExpression.java:39) > at > org.apache.calcite.linq4j.tree.TernaryExpression.accept(TernaryExpression.java:47) > at > org.apache.calcite.linq4j.tree.DeclarationStatement.accept(DeclarationStatement.java:45) > at > org.apache.calcite.linq4j.tree.DeclarationStatement.accept(DeclarationStatement.java:27) > at > org.apache.calcite.linq4j.tree.BlockBuilder.optimize(BlockBuilder.java:426) > at > org.apache.calcite.linq4j.tree.BlockBuilder.toBlock(BlockBuilder.java:340) > at > org.apache.calcite.rex.RexExecutorImpl.compile(RexExecutorImpl.java:102) > at > org.apache.calcite.rex.RexExecutorImpl.compile(RexExecutorImpl.java:68) > at > org.apache.calcite.rex.RexExecutorImpl.reduce(RexExecutorImpl.java:133) > at > org.apache.calcite.rex.RexSimplify.simplifyCast(RexSimplify.java:2272) > at org.apache.calcite.rex.RexSimplify.simplify(RexSimplify.java:292) > at > org.apache.calcite.rex.RexSimplify.simplifyUnknownAs(RexSimplify.java:250) > at > org.apache.calcite.rex.RexSimplify.simplifyPreservingType(RexSimplify.java:189) > at > org.apache.calcite.rex.RexSimplify.simplifyPreservingType(RexSimplify.java:184) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)