[
https://issues.apache.org/jira/browse/CALCITE-6301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825861#comment-17825861
]
Oliver Lee commented on CALCITE-6301:
-------------------------------------
[~julianhyde]
We discussed adding in two more test cases
# project bypass fields but not the must-filter field, and inspect what
happens if bypass field is filtered on enclosing query (should pass)
# project mustFilter fields but not the bypass fields (this should fail if
enclosing query does not filter on the mustFilter fields)
I've updated the PR with an additional commit with the test cases, first 2
belonging to (1) and the third for (2)
Commit:
[https://github.com/olivrlee/calcite/commit/8de5f6ec232bd235632f92996be2f97df31f0581]
A test for (1) does not pass and needs additional handling.
> Extend ‘Must-filter’ columns to support a conditional bypass list
> -----------------------------------------------------------------
>
> Key: CALCITE-6301
> URL: https://issues.apache.org/jira/browse/CALCITE-6301
> Project: Calcite
> Issue Type: Improvement
> Reporter: Oliver Lee
> Assignee: Oliver Lee
> Priority: Major
> Labels: pull-request-available
>
> In CALCITE-6219 we introduced SemanticTable, where tables that implement this
> interface can define fields to be ‘must-filter’, and a query without those
> filters in any of its WHERE or HAVING clauses, it will throw a validation
> error.
>
> I would like to extend this functionality to support a by-pass list of fields
> such that if any field from this secondary list is present in a WHERE /
> HAVING clause, then the must-filter fields can be ignored and will not raise
> an exception if not filtered on.
>
> Ex.
>
> EMP table specifies the following:
> Must-filter-fields: [EMPNO, DEPTNO]
> Bypass-fields: [ENAME, SALARY]
>
>
> SELECT * FROM EMP WHERE EMPNO = 1 and DEPTNO = 2 -> No error
> SELECT * FROM EMP WHERE EMPNO = 1 -> Error
> SELECT * FROM EMP WHERE EMPNO = 1 and ENAME = ’name’ -> No error
> SELECT * FROM EMP WHERE ENAME = ’name’ -> No error
> SELECT * FROM EMP WHERE SALARY > 10 -> No error
>
>
>
> Again, special considerations are for handling
>
> * Joins
> * CTEs
> * Subqueries
>
>
> And a similar exhaustive suite of tests like the one for CALCITE-6219 should
> be employed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
