[ 
https://issues.apache.org/jira/browse/CALCITE-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826853#comment-17826853
 ] 

Mihai Budiu commented on CALCITE-6324:
--------------------------------------

Upon further reflection I think that leaving the types as they are is simplest. 
Since the compiler cannot infer a safe bound, it should leave this to the user, 
who may know something about the data.
So we take the Oracle approach, the existing implementation.
I will close this issue.

> Type inferred for result of STDDEV, VAR_SAMP, etc. is incorrect
> ---------------------------------------------------------------
>
>                 Key: CALCITE-6324
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6324
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.36.0
>            Reporter: Mihai Budiu
>            Assignee: Mihai Budiu
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.37.0
>
>
> These functions are all use the same type inference algorithm, essentially 
> the algorithm used by AVG.
> But if the values processed are decimal, STDDEV (and others) need much higher 
> precision to represent the result. (I am not sure that the inference is right 
> for integer types either, btw.)
> This surfaced during the implementation of a fix for [CALCITE-6322]: if we 
> use the type inferred for these functions, the result overflows and causes a 
> runtime exception.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to