[ 
https://issues.apache.org/jira/browse/CALCITE-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842393#comment-17842393
 ] 

Sergey Nuyanzin edited comment on CALCITE-6393 at 4/30/24 1:56 PM:
-------------------------------------------------------------------

{quote}
What other exception do you get with jdk11+?
{quote}
if I build it with jdk11 (in my case 11.0.20.1 (Eclipse Adoptium 11.0.20.1+1))
then i get this instead of {{ArrayIndexOutOfBoundsException}}
{noformat}
RemapperTest > ccalcite37WithCheck() FAILED
    java.lang.IllegalArgumentException: Invalid type reference sort 0x10
        at 
org.objectweb.asm.util.CheckMethodAdapter.visitTypeAnnotation(CheckMethodAdapter.java:524)
        at 
org.objectweb.asm.MethodVisitor.visitTypeAnnotation(MethodVisitor.java:181)
        at 
org.objectweb.asm.commons.MethodRemapper.visitTypeAnnotation(MethodRemapper.java:94)
        at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1453)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:745)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:425)
        at remapper.bug.RemapperTest.runTest(RemapperTest.java:63)
        at remapper.bug.RemapperTest.ccalcite37WithCheck(RemapperTest.java:49)
 
{noformat}

UPD: with jdk17 (in my case 17.0.10 (Eclipse Adoptium 17.0.10+7))
the exception is going away


was (Author: sergey nuyanzin):
{quote}
What other exception do you get with jdk11+?
{quote}
if I build it with jdk11 (in my case 11.0.20.1 (Eclipse Adoptium 11.0.20.1+1))
then i get this instead of {{ArrayIndexOutOfBoundsException}}
{noformat}
RemapperTest > ccalcite37WithCheck() FAILED
    java.lang.IllegalArgumentException: Invalid type reference sort 0x10
        at 
org.objectweb.asm.util.CheckMethodAdapter.visitTypeAnnotation(CheckMethodAdapter.java:524)
        at 
org.objectweb.asm.MethodVisitor.visitTypeAnnotation(MethodVisitor.java:181)
        at 
org.objectweb.asm.commons.MethodRemapper.visitTypeAnnotation(MethodRemapper.java:94)
        at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1453)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:745)
        at org.objectweb.asm.ClassReader.accept(ClassReader.java:425)
        at remapper.bug.RemapperTest.runTest(RemapperTest.java:63)
        at remapper.bug.RemapperTest.ccalcite37WithCheck(RemapperTest.java:49)
 
{noformat}

> Byte code of SqlFunctions is invalid
> ------------------------------------
>
>                 Key: CALCITE-6393
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6393
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Sergey Nuyanzin
>            Priority: Major
>
> The issue is a result of testing of Apache Calcite 1.37.0 rc 4 in this thread 
> [1]
> There is test project andprocedure provided by [~MasseGuillaume] [2] (see 
> also original thread where this was first discussed [3])
> it shows that since Calcite 1.36.0 it starts failing as 
> {noformat}
>     java.lang.ArrayIndexOutOfBoundsException: Index 65536 out of bounds for 
> length 297
>         at org.objectweb.asm.ClassReader.readLabel(ClassReader.java:2695)
>         at org.objectweb.asm.ClassReader.createLabel(ClassReader.java:2711)
>         at 
> org.objectweb.asm.ClassReader.readTypeAnnotations(ClassReader.java:2777)
>         at org.objectweb.asm.ClassReader.readCode(ClassReader.java:1929)
>         at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1515)
>         at org.objectweb.asm.ClassReader.accept(ClassReader.java:745)
> {noformat}
> Also  since Calcite 1.27.0 it starts failing as 
> {noformat}
>     java.lang.IllegalArgumentException: Invalid end label (must be visited 
> first)
>         at 
> org.objectweb.asm.util.CheckMethodAdapter.checkLabel(CheckMethodAdapter.java:1453)
>         at 
> org.objectweb.asm.util.CheckMethodAdapter.visitLocalVariableAnnotation(CheckMethodAdapter.java:996)
>         at 
> org.objectweb.asm.MethodVisitor.visitLocalVariableAnnotation(MethodVisitor.java:757)
>         at 
> org.objectweb.asm.commons.MethodRemapper.visitLocalVariableAnnotation(MethodRemapper.java:257)
>         at org.objectweb.asm.ClassReader.readCode(ClassReader.java:2614)
>         at org.objectweb.asm.ClassReader.readMethod(ClassReader.java:1515)
> {noformat}
> [1] https://lists.apache.org/thread/n6cs1l86mt6fc5q8pcxr97czs3p6w65f
> [2] https://github.com/MasseGuillaume/asm-remapper-bug
> [3] https://lists.apache.org/thread/o736wz4qnr4l285bj5gv073cy0qll9t0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to