[ https://issues.apache.org/jira/browse/CALCITE-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844792#comment-17844792 ]
Mihai Budiu commented on CALCITE-6392: -------------------------------------- 1 makes sense. You could also consider adding only a few patterns in each PR. A big more work for you, but hopefully less reviewer fatigue. > Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp > --------------------------------------------------------------------- > > Key: CALCITE-6392 > URL: https://issues.apache.org/jira/browse/CALCITE-6392 > Project: Calcite > Issue Type: Sub-task > Reporter: Norman Jordan > Assignee: Norman Jordan > Priority: Minor > > Many of the date/time format patterns supported by PostgreSQL 14 are not > supported in Calcite. > * HH > * US > * SSSS > * SSSSS > * AM > * A.M. > * am > * a.m. > * PM > * P.M. > * pm > * p.m. > * Y,YYY > * YYY > * Y > * IYYY > * IYY > * IY > * I > * BC > * B.C. > * bc > * b.c. > * AD > * A.D. > * ad > * a.d. > * MONTH > * month > * MON > * mon > * DAY > * day > * Dy > * dy > * IDDD > * ID > * TZH > * TZM > * OF > There are also template pattern modifiers that need to be supported. > * FM (prefix) > * TH (suffix) > * th (suffix) > * FX (prefix) > * TM (prefix) > Some format patterns in Calcite behave differently from PostgreSQL 14. > * FF1 > * FF2 > * FF4 > * FF5 > * FF6 > Also verify that the other existing format strings produce results that match > PostgreSQL 14. -- This message was sent by Atlassian Jira (v8.20.10#820010)