[ 
https://issues.apache.org/jira/browse/CALCITE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855763#comment-17855763
 ] 

Julian Hyde commented on CALCITE-6414:
--------------------------------------

I have decomposed this PR into two (one to add the functions - see CALCITE-6441 
- and one to fix the JDBC adapter's SQL generation) and will merge to main 
shortly.

> Snowflake JDBC adapter should generate BOOLOR_AGG, BOOLAND_AGG for MAX, MIN 
> on BOOLEAN values
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-6414
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6414
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Justin Swett
>            Assignee: Nitish Kumar
>            Priority: Trivial
>              Labels: pull-request-available
>
> The rewriteMacMInExpr is generating incorrect SQL for Snowflake.
> Instead of BOOL_OR, it should be BOOLOR_AGG and instead BOOL_AND, it should 
> be BOOLAND_AGG
>  
> I think adding the following expectation in testMaxMinOnBooleanColumn should 
> repro:
>  
> {code:java}
> @Test void testMaxMinOnBooleanColumn(){
>  ...    
>     final String expectedSnowflake = "SELECT BOOLOR_AGG(\"brand_name\" = 
> 'a'), "
>          + "BOOLAND_AGG(\"brand_name\" = 'a'), "
>          + "MIN(\"brand_name\")\n"
>          + "FROM \"foodmart\".\"product\"";
> sql(query)
>   .ok(expected)
>   .withBigQuery().ok(expectedBigQuery)         
>   .withPostgresql().ok(expectedPostgres)
>   .withSnowflak().ok(expectedSnowflake)
>   .withRedshift().ok(expectedPostgres);
> }
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to