[ https://issues.apache.org/jira/browse/CALCITE-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865238#comment-17865238 ]
Julian Hyde edited comment on CALCITE-6456 at 7/11/24 9:54 PM: --------------------------------------------------------------- Can you amend the description with a simple example where MySQL and BigQuery give different results. In reference.md, rename the numeric1 and numeric2 parameters for both LOG to "numeric" and "base". It's just clearer. Similarly in {{SqlFunctions}}. The {{SqlFunctions.log}} function should not depend on {{SqlLibrary}}. That seems like a layering violation. Change the argument back to {{int}} (or could it be {{boolean}}?) "MySQL" is capitalized as "MySQL", not "Mysql". was (Author: julianhyde): Can you amend the description with a simple example where MySQL and BigQuery give different results. In reference.md, rename the numeric1 and numeric2 parameters for both LOG to "numeric" and "base". It's just clearer. Similarly in {{SqlFunctions}}. The {{SqlFunctions.log}} function should not depend on {{SqlLibrary}}. That seems like a layering violation. Change the argument back to {{int}} (or could it be {{boolean}}?) > The Mysql log function rule LOG(x, base) is equivalent to LOG(base)/LOG(x) > -------------------------------------------------------------------------- > > Key: CALCITE-6456 > URL: https://issues.apache.org/jira/browse/CALCITE-6456 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.37.0 > Reporter: Caican Cai > Priority: Major > Fix For: 1.38.0 > > > The fact should be that the log function in mysql should be equivalent to > LOG(x, base) is equivalent to LOG(x)/LOG(base), and the calculation is not > the same as bigquery -- This message was sent by Atlassian Jira (v8.20.10#820010)