[
https://issues.apache.org/jira/browse/CALCITE-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18019785#comment-18019785
]
Alessandro Solimando edited comment on CALCITE-7179 at 9/12/25 7:34 AM:
------------------------------------------------------------------------
Fixed via
[{{229ffcb}}|https://github.com/apache/calcite/commit/229ffcb654c9af3387d3835d65947eed794fd614],
thanks [~jensen] for reviewing!
was (Author: asolimando):
Fixed via
[{{229ffcb}}|https://github.com/apache/calcite/commit/229ffcb654c9af3387d3835d65947eed794fd614],
thanks [~zhenchen] for reviewing!
> Improve error message for QuidemTest
> ------------------------------------
>
> Key: CALCITE-7179
> URL: https://issues.apache.org/jira/browse/CALCITE-7179
> Project: Calcite
> Issue Type: Test
> Components: tests
> Affects Versions: 1.40.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Trivial
> Labels: pull-request-available
>
> Existing error message (computed and expected are swapped w.r.t. the diff
> that is being printed, see
> [code|https://github.com/apache/calcite/blob/calcite-1.40.0/testkit/src/main/java/org/apache/calcite/test/QuidemTest.java#L216-L219]):
> {noformat}
> Files differ:
> /Users/alessandro.solimando/git/calcite/core/build/quidem/test/sql/sub-query.iq
>
> /Users/alessandro.solimando/git/calcite/core/build/resources/test/sql/sub-query.iq
> {noformat}
> Updated error message (aligned with that of RelOptRulesTest):
> {noformat}
> Files differ:
> diff
> /Users/alessandro.solimando/git/calcite/core/build/resources/test/sql/sub-query.iq
>
> /Users/alessandro.solimando/git/calcite/core/build/quidem/test/sql/sub-query.iq
> {noformat}
> The new error message can be copy-pasted as is to have the same diff in
> command line as the one shown (which also comes handy for copying the
> computed file to become the new expected, after validation).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
