[
https://issues.apache.org/jira/browse/CALCITE-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052490#comment-18052490
]
Zhen Chen commented on CALCITE-7381:
------------------------------------
[~julianhyde] I think the design of
"!set" is good. Within the same session, we should ensure its proper usage
ourselves. Actually, even with
"!push" and
"!pop", it would still require two operations. I believe for now, we just need
to add
"!set xxx default_value" after the problematic cases, and it’s sufficient as
long as reviewers can be aware of this issue.
> Parameters modified by !set must be restored to their default values in
> Quidem test
> ------------------------------------------------------------------------------------
>
> Key: CALCITE-7381
> URL: https://issues.apache.org/jira/browse/CALCITE-7381
> Project: Calcite
> Issue Type: Test
> Components: core
> Reporter: Zhen Chen
> Priority: Major
>
> For example in sub-query.iq
> {code:java}
> !set insubquerythreshold 0
> !set trimfields false{code}
> However, insubquerythreshold was not restored to 20 and trimfields was not
> restored to true.
> Other .iq files also exhibit similar issues. This can affect the correctness
> of subsequent tests to some extent.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
