[ 
https://issues.apache.org/jira/browse/CALCITE-6908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081972#comment-18081972
 ] 

Stamatis Zampetakis commented on CALCITE-6908:
----------------------------------------------

Thanks for the explanation [~caicancai]! If there is no too much code 
duplication with the existing Redis adapter and the two are sufficiently 
disjoint then it seems beneficial to implement the Kvrocks adapter as a 
separate module. 

Is the PR ready for review? Sonar says that there is 0.0% coverage on new code. 
Is it a config problem or we are really lack tests in this area?

> Apache Kvrocks adapter
> ----------------------
>
>                 Key: CALCITE-6908
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6908
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Caican Cai
>            Assignee: Caican Cai
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.42.0
>
>
> Apache Kvrocks is a distributed key value NoSQL database that uses RocksDB as 
> storage engine and is compatible with Redis protocol and And kvrocks also 
> supports querying data through sql , we can adapt it, maybe most of it is 
> similar to the redis adapter. But I may want to write a new module and 
> refactor and solve some problems of the current redis adapter, such as 
> adapting redis sql and compatibility with more redis commands.
> https://github.com/apache/kvrocks
> https://kvrocks.apache.org/docs/supported-commands#search-commands



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to