[
https://issues.apache.org/jira/browse/CALCITE-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yu Xu resolved CALCITE-7693.
----------------------------
Resolution: Fixed
Fixed in
[https://github.com/apache/calcite/commit/738a0d7b1c9acdad7d2c450ef7a9cdd2c3923183]
Thank you for the review! [~krooswu]
> Move MongoDB LIKE-to-regex conversion into runtime.Like for consistency
> -----------------------------------------------------------------------
>
> Key: CALCITE-7693
> URL: https://issues.apache.org/jira/browse/CALCITE-7693
> Project: Calcite
> Issue Type: Improvement
> Components: mongodb-adapter
> Affects Versions: 1.42.0
> Reporter: Yu Xu
> Assignee: Yu Xu
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.43.0
>
>
> Follow-up to the initial MongoDB LIKE
> support(https://issues.apache.org/jira/browse/CALCITE-7673). In review it was
> noted that the SQL-LIKE-to-regex conversion logic embedded in MongoFilter
> duplicated a pattern Calcite already establishes in
> org.apache.calcite.runtime.Like (see Like.sqlToRegexLike). Keeping the
> conversion inside the adapter meant a second, independently-maintained
> escape/wildcard translator with its own special-character table and error
> handling.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)