[
https://issues.apache.org/jira/browse/CALCITE-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18113024#comment-18113024
]
Mihai Budiu commented on CALCITE-7767:
--------------------------------------
They are open because no one bothered to close them.
Some of them may be duplicates for the same issue. Checking for duplicates is
not easy.
Closing issues is not a goal in itself, fixing the bugs behind them, is.
Certifying that the bugs are solved is also useful.
> Re-enable disabled in RelMetadataTest with updated selectivity expectations
> ---------------------------------------------------------------------------
>
> Key: CALCITE-7767
> URL: https://issues.apache.org/jira/browse/CALCITE-7767
> Project: Calcite
> Issue Type: Task
> Components: tests
> Reporter: Diveyam Mishra
> Assignee: Diveyam Mishra
> Priority: Trivial
> Labels: pull-request-available
>
> h4. Problem
> In {{{}RelMetadataTest.java{}}}, five tests verifying
> {{RelMetadataQuery#getPercentageOriginalRows}} have been disabled since the
> initial Optiq/Eigenbase migration:
> * {{testPercentageOriginalRowsTwoFilters}}
> * {{testPercentageOriginalRowsRedundantFilter}}
> * {{testPercentageOriginalRowsJoinTwoFilters}}
> * {{testPercentageOriginalRowsUnionLittleFilter}}
> * {{testPercentageOriginalRowsUnionBigFilter}}
> h4. Cause
> These legacy tests were written under early Optiq assumptions where all
> equality predicates were assigned a fixed default selectivity
> ({{{}DEFAULT_EQUAL_SELECTIVITY = 0.15{}}}).
> As Calcite's metadata framework evolved to incorporate schema knowledge
> (specifically identifying {{deptno}} as a unique primary key on table
> {{{}dept{}}}, yielding an exact selectivity of {{{}1.0 / DEPT_SIZE =
> 0.25{}}}), the hardcoded assertions expecting {{0.15}} and {{0.0225}} failed.
> Rather than updating the formulas to reflect Calcite's improved metadata
> formulas, {{@Disabled}} was added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
