[
https://issues.apache.org/jira/browse/CALCITE-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mihai Budiu resolved CALCITE-7767.
----------------------------------
Fix Version/s: 1.43.0
Resolution: Fixed
Fixed in
[https://github.com/apache/calcite/commit/194ce5451393d5226112c8597e5e60fd70b64a9f]
Thank you for the fix [~diveyam02]
> Re-enable disabled in RelMetadataTest with updated selectivity expectations
> ---------------------------------------------------------------------------
>
> Key: CALCITE-7767
> URL: https://issues.apache.org/jira/browse/CALCITE-7767
> Project: Calcite
> Issue Type: Task
> Components: tests
> Reporter: Diveyam Mishra
> Assignee: Diveyam Mishra
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 1.43.0
>
>
> h4. Problem
> In {{{}RelMetadataTest.java{}}}, five tests verifying
> {{RelMetadataQuery#getPercentageOriginalRows}} have been disabled since the
> initial Optiq/Eigenbase migration:
> * {{testPercentageOriginalRowsTwoFilters}}
> * {{testPercentageOriginalRowsRedundantFilter}}
> * {{testPercentageOriginalRowsJoinTwoFilters}}
> * {{testPercentageOriginalRowsUnionLittleFilter}}
> * {{testPercentageOriginalRowsUnionBigFilter}}
> h4. Cause
> These legacy tests were written under early Optiq assumptions where all
> equality predicates were assigned a fixed default selectivity
> ({{{}DEFAULT_EQUAL_SELECTIVITY = 0.15{}}}).
> As Calcite's metadata framework evolved to incorporate schema knowledge
> (specifically identifying {{deptno}} as a unique primary key on table
> {{{}dept{}}}, yielding an exact selectivity of {{{}1.0 / DEPT_SIZE =
> 0.25{}}}), the hardcoded assertions expecting {{0.15}} and {{0.0225}} failed.
> Rather than updating the formulas to reflect Calcite's improved metadata
> formulas, {{@Disabled}} was added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
