[ 
https://issues.apache.org/jira/browse/CALCITE-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129096#comment-18129096
 ] 

Stamatis Zampetakis commented on CALCITE-7871:
----------------------------------------------

Large contributions are hard to follow if everything is squashed into a single 
commit.  Moreover, our [contributions 
guidelines|https://calcite.apache.org/develop/#contributing] encourage folks to 
address review comments in separate commits (without force push). Maybe a 
broader discussion is needed before starting enforcing this in CI.

> Validate pull request titles and require a single matching commit
> -----------------------------------------------------------------
>
>                 Key: CALCITE-7871
>                 URL: https://issues.apache.org/jira/browse/CALCITE-7871
>             Project: Calcite
>          Issue Type: Wish
>    Affects Versions: 1.42.0
>            Reporter: Zhen Chen
>            Assignee: Zhen Chen
>            Priority: Minor
>              Labels: pull-request-available
>
> Calcite’s pull request template outlines contribution guidelines, but these 
> rules currently rely on manual review. Given the significant volume of 
> AI-generated contributions, manual oversight is prone to oversights; 
> therefore, we should implement automated PR checks to enforce consistent 
> titling and single-commit requirements.
> Expected behavior:
>  - Require exactly one commit per PR. Its subject must exactly match the full 
> PR title; an additional commit message body is allowed.
>  - Require the PR title, excluding the CALCITE-XXXX prefix, to exactly match 
> the Jira issue title. PR and Jira descriptions are not checked.
>  - Allow [TEST] Description for test additions and [MINOR] Description for 
> other minor changes. These prefixes skip Jira validation but retain the 
> commit requirements.
>  - Automatically run when a PR is opened, edited, synchronized, reopened, or 
> marked ready for review. Merging into main must not trigger this check.
>  - Report actionable errors for invalid titles, mismatches, multiple commits, 
> or unavailable Jira issues.
>  - Update the PR template to explain the rules and exceptions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to