[
https://issues.apache.org/jira/browse/CALCITE-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250585#comment-14250585
]
Julian Hyde commented on CALCITE-528:
-------------------------------------
I agree, we probably miss a few bugs in case-insensitive validation because we
use Lex.ORACLE. We would miss some other bugs if the house style were something
else. Feel free to add tests for different case-sensitivity settings.
But it's good that there is a "house style" if a test is checking something
unrelated to parsing/validation, e.g. making sure that the SUBSTRING function
returns the right result. And for better or worse, the house style is Oracle.
That line in SqlToRelConverter is correct. As I said earlier, in
RelNode/RexNode world, field names are case sensitive. I put the constant on a
separate line because I wanted to be explicit.
> Creating output row type of a Join does not obey case-sensitivity flags
> -----------------------------------------------------------------------
>
> Key: CALCITE-528
> URL: https://issues.apache.org/jira/browse/CALCITE-528
> Project: Calcite
> Issue Type: Bug
> Affects Versions: 0.9.1-incubating
> Reporter: Aman Sinha
> Assignee: Julian Hyde
>
> In JoinRelBase.createJoinType() which creates a row type of the output row, a
> HashSet of String is used to keep track of unique field names. The field
> names 'column1' and 'Column1' will both be stored. This creates a problem
> for systems which are treating identifiers as case-insensitive (such as
> Drill) which rely on a Project below a Join to create unique names if the
> join columns are the same name (regardless of case).
> Ideally, the comparison for this should be done based on the criteria
> specified in the Lex settings when instantiating the
> SqlParser.ParserConfigImpl. So, if the parser was created with MYSQL Lex
> settings (see Lex.java), it should be obeyed by the
> JoinRelBase.createJoinType().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
