[
https://issues.apache.org/jira/browse/CALCITE-571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297391#comment-14297391
]
Julian Hyde commented on CALCITE-571:
-------------------------------------
I was approaching it as a bug - it used to throw AssertionError, and after my
fix it does not. Functional improvements should be logged as separate jira
cases.
In general I'm not in favor of TODO comments in the code. They go stale and
confuse people. And, there is a temptation to use a TODO as an excuse to commit
incomplete functionality. The place for wish lists is Jira.
> ReduceExpressionsRule tries to reduce SemiJoin condition to non-equi condition
> ------------------------------------------------------------------------------
>
> Key: CALCITE-571
> URL: https://issues.apache.org/jira/browse/CALCITE-571
> Project: Calcite
> Issue Type: Bug
> Reporter: Jesus Camacho Rodriguez
> Assignee: Julian Hyde
> Fix For: 1.0.0-incubating
>
>
> Hive's unit test that reproduces the problem: vector_mapjoin_reduce
> Stack Trace:
> {noformat}
> Unexpected exception java.lang.AssertionError
> at org.apache.calcite.rel.core.SemiJoin.copy(SemiJoin.java:82)
> at org.apache.calcite.rel.core.SemiJoin.copy(SemiJoin.java:42)
> at
> org.apache.calcite.rel.rules.ReduceExpressionsRule$3.onMatch(ReduceExpressionsRule.java:224)
> at
> org.apache.calcite.plan.AbstractRelOptPlanner.fireRule(AbstractRelOptPlanner.java:326)
> at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:515)
> at
> org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:392)
> at
> org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:285)
> at
> org.apache.calcite.plan.hep.HepInstruction$RuleCollection.execute(HepInstruction.java:72)
> at
> org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:207)
> at
> org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:194)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
