[
https://issues.apache.org/jira/browse/CALCITE-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307956#comment-14307956
]
Vladimir Sitnikov edited comment on CALCITE-584 at 2/5/15 8:46 PM:
-------------------------------------------------------------------
{quote} The interpreter was a compromise because Julian rightly pointed out
that we have very poor test coverage if you pull enumerable into a separate
module{quote}
Can you please pin-point the discussion?
I do not think we'll lose in test coverage if we move executor out of
core-optimizer and consider "executor" as "additional integration test that
verifies core-optimizer".
How that would lower the test coverage?
was (Author: vladimirsitnikov):
{quote} The interpreter was a compromise because Julian rightly pointed out
that we have very poor test coverage if you pull enumerable into a separate
module{quote}
Can you please pin-point the discussion?
I do not think we'll lose in test coverage if move executor out of
core-optimizer and consider "executor" as "additional integration test that
verifies core-optimizer".
How that would lower the test coverage?
> Allow TableMacro to return Table other than TranslatableTable
> -------------------------------------------------------------
>
> Key: CALCITE-584
> URL: https://issues.apache.org/jira/browse/CALCITE-584
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
>
> The TableMacro.apply method used to return Table but in
> https://github.com/apache/incubator-calcite/commit/aa1f0983c126c23466deb990c96d6ff2dffd908c
> this changed to TranslatableTable. It seems reasonable to allow TableMacro
> to return other sub-types of Table, for example ScannableTable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
