[ 
https://issues.apache.org/jira/browse/CALCITE-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350949#comment-14350949
 ] 

Julian Hyde commented on CALCITE-611:
-------------------------------------

I have reviewed all uses of Aggregate.getGroupCount to make sure that they look 
for indicator fields.

In AggregateStarTableRule:{code}
            public int getSourceOpt(int source) {
              if (source < aggregate.getGroupCount()) {
                int in = tileKey.dimensions.nth(source);
                return aggregate.getGroupSet().indexOf(in);
              }
              Lattice.Measure measure =
                  measures.get(source - aggregate.getGroupCount());
              int i = tileKey.measures.indexOf(measure);
              assert i >= 0;
              return tileKey.dimensions.cardinality() + i;
            }
{code}

Can you please fix that as part of this bug? The simplest way might be to throw 
AssertionError if there are indicators.

Everywhere else looks OK.

> Method setAggChildKeys should take into account indicator columns of 
> Aggregate operator
> ---------------------------------------------------------------------------------------
>
>                 Key: CALCITE-611
>                 URL: https://issues.apache.org/jira/browse/CALCITE-611
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: next
>
>
> The method {{setAggChildKeys}} in {{RelMdUtil}} should take into account 
> indicator columns of Aggregate operator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to