[ 
https://issues.apache.org/jira/browse/CALCITE-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383407#comment-14383407
 ] 

Julian Hyde commented on CALCITE-631:
-------------------------------------

I'm trying out the new patch. The costing changes you have made to JdbcJoin 
cause the test suite to take about 10x longer to run, swamp all cores with 
garbage collection activity, and in some cases it even crash the JVM. Did you 
see the same when you ran the test?

I can't accept the patch as it stands.

I presume that the costing changes cause Jdbc plans to be used rather than 
Enumerable. If I disable the cost changes, JdbcAdapterTest gives different 
results than expected. Could you maybe run JdbcAdapterTest with 
EnumerableJoinRule disabled, so it would choose JdbcJoin even if it has the 
current cost model?

> Push theta joins down to JDBC adapter
> -------------------------------------
>
>                 Key: CALCITE-631
>                 URL: https://issues.apache.org/jira/browse/CALCITE-631
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Ng Jiunn Jye
>            Assignee: Julian Hyde
>             Fix For: next
>
>         Attachments: [CALCITE-631]JdbcJoinToSupportNonEquiJoin.2.patch, 
> [CALCITE-631]JdbcJoinToSupportNonEquiJoin.patch
>
>
> Currently, the JdbcJoin only support EquiJoin. ie select * from tab1 inner 
> join tab2 on tab1.col1=tab2.col2
> NonEqui join are not supported in JdbcJoin, thus resulting execution plan 
> which uses EnumerationJoin and EnumerableCalc for joining and not pushing the 
> join down to remote database. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to