[
https://issues.apache.org/jira/browse/CALCITE-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485490#comment-14485490
]
Julian Hyde commented on CALCITE-674:
-------------------------------------
Review comments:
* Clarify the "Outer joins cannot be permuted." comment at the top of
JoinCommuteRule
* Change the "The singleton" comment, which is no longer true
* Add an overloaded constructor and deprecate the current one (to be removed
before 2.0)
* Add a test to RelOptRulesTest.java
> Add a SWAP_OUTER static instance to JoinCommuteRule
> ---------------------------------------------------
>
> Key: CALCITE-674
> URL: https://issues.apache.org/jira/browse/CALCITE-674
> Project: Calcite
> Issue Type: Improvement
> Affects Versions: 1.2.0-incubating
> Reporter: Maryann Xue
> Assignee: Julian Hyde
> Priority: Minor
> Fix For: next
>
> Attachments: CALCITE-674.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> To create another static instance of JoinCommuteRule to enable swapping outer
> joins as JoinCommuteRule.INSTANCE does not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
