[
https://issues.apache.org/jira/browse/CALCITE-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494498#comment-14494498
]
Julian Hyde commented on CALCITE-676:
-------------------------------------
Correct. There was no bug in AggregateJoinTransposeRule.
I made some changes to the "Add a project if the group set is not in the same
order or contains duplicates." section which were mostly just changing
formatting. When I changed
{code}if (!newGroupSet.toList().equals(newKeys)){code}
to
{code}if (!newKeys.equals(aggregate.getGroupSet().asList())){code}
it was not an improvement, except that it removed a warning about comparing
lists of different types. I'll change that section back.
A permuting project may be required
> AssertionError in GROUPING SETS query
> -------------------------------------
>
> Key: CALCITE-676
> URL: https://issues.apache.org/jira/browse/CALCITE-676
> Project: Calcite
> Issue Type: Bug
> Reporter: Julian Hyde
> Assignee: Julian Hyde
> Fix For: next
>
> Attachments: CALCITE-676.1.patch
>
>
> If AggregateJoinTransposeRule and AggregateProjectMergeRule are both enabled,
> and you run a query with grouping sets, you can get an AssertionError. For
> example, {code}Error while executing command CheckResultCommand [sql: select
> emp.deptno as e, dept.deptno as d
> > from "scott".emp join "scott".dept using (deptno)
> > group by cube(emp.deptno, dept.deptno)
> > ]
> > java.lang.AssertionError: Internal error: Error while applying rule
> > AggregateProjectMergeRule, args
> > [rel#1144:LogicalAggregate.NONE.[](input=rel#1143:Subset#4.NONE.[],group={0,
> > 1},groups=[{0, 1}, {0}, {1}, {}],indicator=true),
> > rel#1163:LogicalProject.NONE.[](input=rel#1162:Subset#7.NONE.[],DEPTNO=$1,DEPTNO0=$0)]
> > at org.apache.calcite.util.Util.newInternal(Util.java:743)
> > at
> > org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:251)
> > at
> > org.apache.calcite.plan.volcano.VolcanoPlanner.findBestExp(VolcanoPlanner.java:798)
> > at org.apache.calcite.tools.Programs$5.run(Programs.java:272)
> > at
> > org.apache.calcite.tools.Programs$SequenceProgram.run(Programs.java:320)
> > at org.apache.calcite.prepare.Prepare.optimize(Prepare.java:142)
> > at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:280)
> > at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:188)
> > at
> > org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:521)
> > at
> > org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:417)
> > at
> > org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:386)
> > at
> > org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:174)
> > at
> > org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:489)
> > at
> > org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:474)
> > at
> > org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:109)
> > at
> > org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:129)
> > at
> > net.hydromatic.quidem.Quidem$CheckResultCommand.execute(Quidem.java:690)
> > at
> > net.hydromatic.quidem.Quidem$CompositeCommand.execute(Quidem.java:926)
> > at net.hydromatic.quidem.Quidem.execute(Quidem.java:193)
> > at org.apache.calcite.test.JdbcTest.checkRun(JdbcTest.java:4401)
> > at org.apache.calcite.test.JdbcTest.testRunJoin(JdbcTest.java:4349)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> > at
> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at
> > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > at
> > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > at
> > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > at
> > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > at
> > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > at
> > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
> > at
> > com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
> > at
> > com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
> > at
> > com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > at
> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> > at
> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
> > Caused by: java.lang.AssertionError: [{0, 1}, {1}, {0}, {}]
> > at org.apache.calcite.rel.core.Aggregate.<init>(Aggregate.java:132)
> > at
> > org.apache.calcite.rel.logical.LogicalAggregate.<init>(LogicalAggregate.java:65)
> > at
> > org.apache.calcite.rel.logical.LogicalAggregate.copy(LogicalAggregate.java:105)
> > at
> > org.apache.calcite.rel.logical.LogicalAggregate.copy(LogicalAggregate.java:43)
> > at
> > org.apache.calcite.rel.rules.AggregateProjectMergeRule.apply(AggregateProjectMergeRule.java:114)
> > at
> > org.apache.calcite.rel.rules.AggregateProjectMergeRule.onMatch(AggregateProjectMergeRule.java:61)
> > at
> > org.apache.calcite.plan.volcano.VolcanoRuleCall.onMatch(VolcanoRuleCall.java:228){code}
> The problem is that if you have a sorted list of grouping sets [[0, 2], [0],
> [2], []] and you permute the fields 0->2 and 2->1, then the permuted result
> [[2, 1], [2], [1], []] is no longer sorted. ([2] should occur after [1] but
> occurs before.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
