[ 
https://issues.apache.org/jira/browse/CALCITE-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529787#comment-14529787
 ] 

Xavier FH Leong commented on CALCITE-712:
-----------------------------------------

The prepareStatement setMaxRows needs a bit of overhaul, as the current logic 
flow is defunct, one can't setMaxRows on a prepareStatement without the 
statement first created, eventhou the meta prototype have maxRowCount in it, 
one can only set the maxRowCounts after the fact the prepare is called:

  public StatementHandle prepare(ConnectionHandle ch, String sql,
      int maxRowCount) 

The only way to have prepareStatement supporting the setMaxRows, is to have it 
done via RPC, and extend CalciteSignature to have setMaxRows method to 
overwrite the private member during the RPC call.

Open for ideas.

Include [~ndimiduk] in here for Avatica discussion.

> Avatica statement execute return all resultset instead of MaxRows from 
> setMaxRows
> ---------------------------------------------------------------------------------
>
>                 Key: CALCITE-712
>                 URL: https://issues.apache.org/jira/browse/CALCITE-712
>             Project: Calcite
>          Issue Type: Bug
>    Affects Versions: 1.3.0-incubating
>            Reporter: Xavier FH Leong
>            Assignee: Julian Hyde
>              Labels: avatica
>
> setMaxRows is supported, but after moving to JdbcMeta, max row was ignore and 
> full result set is return instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to