[ 
https://issues.apache.org/jira/browse/CALCITE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548006#comment-14548006
 ] 

Xavier FH Leong commented on CALCITE-708:
-----------------------------------------

Hi [~julianhyde], need some guidance, I'd make the RelDataTypeSystem be 
representing for the DatabaseMetaData type info, also found that BasicSqlType 
basically employs all the default precision on the type. I'd move them instead 
to the type system, now mostly all types have the default precision 
represented, eg INTEGER will be INTEGER(10)

So, now the precision info is available and in the rel nodes and plans, this 
means all the unit test that do string compare will fail. Want to check with 
you whether this is the right path, as to me, it shows the type are now 
consistently represented, and also being push down to the rel nodes. What do 
you think?

You can also have a peek on the WIP branch in github. Thanks.

> Avatica and Calcite to support DatabaseMetaData getTypeInfo
> -----------------------------------------------------------
>
>                 Key: CALCITE-708
>                 URL: https://issues.apache.org/jira/browse/CALCITE-708
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Xavier FH Leong
>            Assignee: Julian Hyde
>            Priority: Minor
>              Labels: avatica, metadata
>             Fix For: next
>
>
> http://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getTypeInfo()
>  
> Avatica to call underlying connection database metadata for getTypeInfo to 
> show the database supported type and meta info.
> Calcite to provide the info for the underlying adapter thru SqlTypeName and 
> RelDataType



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to