[ 
https://issues.apache.org/jira/browse/CALCITE-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646313#comment-14646313
 ] 

Milinda Lakmal Pathirage edited comment on CALCITE-822 at 7/29/15 4:44 PM:
---------------------------------------------------------------------------

Fix which removes the incorrect inferring of LogicalAggregate's collations.

With this fix I had to change the test LatticeTest#testJG also. When collation 
inferring logic was there the RelNode to string conversion added some extra 
characters to the output. For example:

- m1=[SUM($5)] becomes m1=[$SUM0($5)]

But I'm not sure about the exact reason behind this. [~julianhyde] may know why 
this is happening when collation metadata is there in LogicalAggregate.



was (Author: milinda):
Fix which removes the incorrect inferring of LogicalAggregate's collations.

With this fix I had to change the test LatticeTest#testJG also. When collation 
inferring logic was there the RelNode to string conversion added some extra 
characters to the output. For example:

- m1=[SUM($5)] becomes m1=[$SUM0($5)]

But I'm not sure about the exact reason behind this. [~julianhyde] may know why 
this is happening when collations are there in LogicalAggregate.


> Incorrect LogicalAggregate collation inferring logic was introduced with the 
> patch for CALCITE-783
> --------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-822
>                 URL: https://issues.apache.org/jira/browse/CALCITE-822
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Milinda Lakmal Pathirage
>            Assignee: Milinda Lakmal Pathirage
>         Attachments: CALCITE-822-0.patch
>
>
> Please refer 
> https://issues.apache.org/jira/browse/CALCITE-783?focusedCommentId=14641378&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14641378
>  for more information.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to