[
https://issues.apache.org/jira/browse/CALCITE-820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648247#comment-14648247
]
Julian Hyde commented on CALCITE-820:
-------------------------------------
Looks good. A few minor things:
1. Rename "isRequireOver" method and "requireOver" field to "requiresOver" to
be consistent with "requiresOrder".
2. I like the approach of having these properties be boolean fields. Please
move the SqlRankFunction.requiresOrder field up to SqlAggFunction and add a
constructor parameter. You should be able to remove requiresOrder() methods in
sub-classes.
3. Mark as "Deprecated // to be removed before 2.0" all but one constructor of
SqlAggFunction. Fix existing code that uses deprecated constructors.
> Window Functions which miss OVER-Clause should trigger error
> ------------------------------------------------------------
>
> Key: CALCITE-820
> URL: https://issues.apache.org/jira/browse/CALCITE-820
> Project: Calcite
> Issue Type: Bug
> Components: core
> Reporter: Sean Hsuan-Yi Chu
> Assignee: Julian Hyde
>
> For instance,
> {code}
> select rank()
> from emp
> {code}
> should have given exception.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
