[ 
https://issues.apache.org/jira/browse/CALCITE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652204#comment-14652204
 ] 

Jinfeng Ni commented on CALCITE-826:
------------------------------------

This seems to be introduced in Calcite-457, when I enabled the logic of push 
down non-ansi join condition in FilterJoinRule.  

The LogicalProject created in FilterJoinRule did not cause problems for Drill.  
In Drill, we have a set of conversion rule, which will convert a LogicalProject 
into a DrillProject. These set of conversion rule, together with Calcite rules, 
including FilterJoinRule, will be passed to planner as a single ruleset. This 
will ensure LogicalProject created in various Calcite rules will eventually be 
converted to DrillProject.

I browse the code a bit. Seems other rules, such as AggregateJoinTranposeRule, 
JoinCommunateRule may also create LogicalProject. If Hive uses those rules in 
the planner, similar problem may show up again. 


  

> Use ProjectFactory in RelOptUtil.pushDownJoinConditions
> -------------------------------------------------------
>
>                 Key: CALCITE-826
>                 URL: https://issues.apache.org/jira/browse/CALCITE-826
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 1.4.0-incubating
>
>
> RelOptUtil.pushDownJoinConditions is called in FilterJoinRule; it might 
> create Project operators, but a ProjectFactory parameter is not provided. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to