[
https://issues.apache.org/jira/browse/CALCITE-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705885#comment-14705885
]
Jinfeng Ni commented on CALCITE-850:
------------------------------------
I applied your commit, and used the new rule in Drill and run couple of unit
testcases. All run fine. I'll run more. But for now, the new rule seems to be
good.
> Remove push down expressions from FilterJoinRule and create a new rule for it
> -----------------------------------------------------------------------------
>
> Key: CALCITE-850
> URL: https://issues.apache.org/jira/browse/CALCITE-850
> Project: Calcite
> Issue Type: Bug
> Reporter: Jesus Camacho Rodriguez
> Assignee: Jesus Camacho Rodriguez
>
> CALCITE-457 added pushing expressions in join conditions into projects below
> the join in the FilterJoinRule, so the expression would be computed
> beforehand and not in the join predicate.
> While this can be an interesting feature for some projects using Calcite, it
> is a different functionality and it should be a standalone independent rule.
> For instance, in Hive we do not want to enable it at the moment, as it causes
> some performance regressions in many test cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
