[ 
https://issues.apache.org/jira/browse/CALCITE-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14969300#comment-14969300
 ] 

Maryann Xue commented on CALCITE-931:
-------------------------------------

[~jcamachorodriguez] The assertion is to test that the traitSet either does not 
contain the RelCollation trait at all or if it does have a RelCollation trait 
it must be equal to the "collation" parameter passed to the constructor. 
Meanwhile the default traitSet in the default "tester" does not have collation 
trait, which means the assert would succeed with the first condition.
So you can see from the new test case in this patch that I created a customized 
"tester" to include the collation trait into the "cluster" so that the 
assertion would go to its second condition.

> Wrong collation trait in SortJoinTransposeRule for right joins.
> ---------------------------------------------------------------
>
>                 Key: CALCITE-931
>                 URL: https://issues.apache.org/jira/browse/CALCITE-931
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Maryann Xue
>            Assignee: Maryann Xue
>            Priority: Minor
>         Attachments: CALCITE-931.patch
>
>
> The traitSet of the new Sort for Join's right child should be replaced with 
> rightCollation.
> {code}
>       newRightInput = sort.copy(sort.getTraitSet(), join.getRight(), 
> rightCollation,
>           sort.offset, sort.fetch);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to