Github user chenerlu commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/877#discussion_r115918125
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeBitMapDimensionDataChunkStore.java
 ---
    @@ -0,0 +1,213 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.datastore.chunk.store.impl.safe;
    +
    +import java.util.BitSet;
    +import java.util.List;
    +
    +import 
org.apache.carbondata.core.scan.filter.executer.AbstractFilterExecuter.FilterOperator;
    +import org.apache.carbondata.core.util.BitSetGroup;
    +import org.apache.carbondata.core.util.ByteUtil;
    +import org.apache.carbondata.core.util.CarbonUtil;
    +
    +/**
    + * Below class will be used to store bitmap dimension data
    + */
    +public class SafeBitMapDimensionDataChunkStore extends 
SafeAbsractDimensionDataChunkStore {
    +
    +  /**
    +   * Size of each value
    +   */
    +  private int columnValueSize;
    +  private byte[][] bitmap_encoded_dictionaries;
    +  private int[] bitmap_data_pages_offset;
    +  private BitSetGroup bitSetGroup;
    +  private boolean isGeneratedBitSetFlg = false;
    +  private byte[] dictionaryData;
    +
    +  public SafeBitMapDimensionDataChunkStore(List<Integer> 
bitmap_encoded_dictionaries,
    +      List<Integer> bitmap_data_pages_length, int columnValueSize) {
    +    super(false);
    +    this.columnValueSize = columnValueSize;
    +    int arraySize = bitmap_encoded_dictionaries.size();
    +    this.bitmap_encoded_dictionaries = new byte[arraySize][];
    +    this.bitmap_data_pages_offset = new 
int[bitmap_data_pages_length.size()];
    +    for (int i = 0; i < arraySize; i++) {
    +      this.bitmap_encoded_dictionaries[i] = ByteUtil
    +          .convertIntToByteArray(bitmap_encoded_dictionaries.get(i), 
columnValueSize);
    +      this.bitmap_data_pages_offset[i] = bitmap_data_pages_length.get(i);
    +    }
    +    this.bitmap_data_pages_offset[arraySize] = 
bitmap_data_pages_length.get(arraySize);
    +
    +  }
    +
    +  /**
    +   * Below method will be used to put the rows and its metadata in offheap
    +   *
    +   * @param invertedIndex
    +   *          inverted index to be stored
    +   * @param invertedIndexReverse
    +   *          inverted index reverse to be stored
    +   * @param data
    +   *          data to be stored
    +   */
    +  @Override
    +  public void putArray(final int[] invertedIndex, final int[] 
invertedIndexReverse,
    +      final byte[] data) {
    +    this.data = data;
    +    loadDictionaryDataIndex();
    +    bitSetGroup = new BitSetGroup(bitmap_encoded_dictionaries.length);
    +
    +    // loadAllBitSets();
    --- End diff --
    
    detele this redundant lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to