Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/916#discussion_r117146059
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterExpressionProcessor.java
 ---
    @@ -137,6 +155,119 @@ public FilterResolverIntf 
getFilterResolver(Expression expressionTree,
       }
     
       /**
    +   * Get the map of required partitions
    +   * The value of "1" in BitSet represent the required partition
    +   * @param expressionTree
    +   * @param partitionInfo
    +   * @param partitioner
    +   * @return
    +   */
    +  @Override public BitSet getFilteredPartitions(Expression expressionTree,
    +      PartitionInfo partitionInfo, Partitioner partitioner) {
    +    return createPartitionFilterTree(expressionTree, 
partitionInfo).applyFilter(partitioner);
    +  }
    +
    +  /**
    +   * create partition filter by basing on pushed-down filter
    +   * @param expressionTree
    +   * @param partitionInfo
    +   * @return
    +   */
    +  public PartitionFilterIntf createPartitionFilterTree(Expression 
expressionTree,
    --- End diff --
    
    make it private


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to