Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/952#discussion_r118632591
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
---
@@ -137,19 +150,31 @@ private BitSet
setFilterdIndexToBitSet(DimensionColumnDataChunk dimensionColumnD
int numerOfRows) {
BitSet bitSet = new BitSet(numerOfRows);
if (dimensionColumnDataChunk instanceof FixedLengthDimensionDataChunk)
{
+ int startIndex = 0;
byte[][] filterValues = dimColumnExecuterInfo.getFilterKeys();
- if (filterValues.length > 1) {
--- End diff --
Any reason for removing this code. Its an optimization added for unsorted
chunk data. As filter values are sorted we can do reverse comparison.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
