Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/987#discussion_r121608684
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageCodec.java
---
@@ -21,15 +21,28 @@
/**
* Codec for a column page data, implementation should not keep state
across pages,
- * caller will use the same object to encode multiple pages.
+ * caller may use the same object to apply multiple pages.
*/
-public interface ColumnCodec {
+public interface ColumnPageCodec {
--- End diff --
Yes, you are right. To make this PR smaller, I suggest to do it in another
PR (EncodingStrategy for dimension)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
