Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/995#discussion_r121879795
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/columnar/BlockIndexerStorageForShort.java
---
@@ -71,14 +72,14 @@ public BlockIndexerStorageForShort(byte[][] keyBlock,
boolean compressData,
return columnWithIndexs;
}
- private short[] extractDataAndReturnIndexes(ColumnWithShortIndex[]
columnWithIndexs,
+ private short[] extractDataAndReturnRowId(ColumnWithShortIndex[]
dataWithRowId,
byte[][] keyBlock) {
--- End diff --
rename parameter keyBlock, and line 58 also need
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
