Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1020#discussion_r121927124
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
@@ -603,7 +603,7 @@ private void copyLocalFileToCarbonStore(String
carbonStoreFilePath, String local
short numberOfByteToStorLength = 2;
// as length part is removed, so each no dictionary value index
// needs to be reshuffled by 2 bytes
- for (int i = 0; i < dataWriterVo.getNoDictionaryCount(); i++) {
+ for (int i = 0; i <
dataWriterVo.getSegmentProperties().getNumberOfNoDictSortColumns(); i++) {
--- End diff --
Please create a local variable for
`dataWriterVo.getSegmentProperties().getNumberOfNoDictSortColumns()`, it is
better not put in loop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
