Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1053#discussion_r122912709
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/ColumnPageStatsVO.java
---
@@ -96,8 +96,7 @@ public void update(Object value) {
case DOUBLE:
max = ((double) max > (double) value) ? max : value;
min = ((double) min < (double) value) ? min : value;
- int num = getDecimalCount((double) value);
- decimal = decimal > num ? decimal : num;
+ decimal = getDecimalCount((double) value);
--- End diff --
for the following value 775678765456789098765432.789 the num variable would
be -8 and according to the earlier logic it would update the decimal value to 0
decimal = 0 > -8 ? 0 : -8
thus the double value would be converted to another dataype that we dont
want.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
