Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1099#discussion_r125541188
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/DataMapStoreManager.java
---
@@ -30,7 +31,7 @@
private static DataMapStoreManager instance = new DataMapStoreManager();
- private Map<DataMapType, Map<String, TableDataMap>> dataMapMappping =
new HashMap<>();
+ private Map<DataMapType, Map<String, AbstractTableDataMap>>
dataMapMappping = new HashMap<>();
--- End diff --
I feel it is better to keep `Map<TableIdentifier, Map<Class,
TableDataMap>>`, thus client can get all data map for one table easily.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
